[Bug 226508] Merge Review: tvtime

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=226508





--- Comment #6 from Tomas Smetana <tsmetana at redhat.com>  2009-06-01 03:48:49 EDT ---
(In reply to comment #5)
> Okay.
> 
> - I wouldn't ship man as %doc.

This is something I couldn't find in the guidelines so I didn't change what I
inherited.  Both make sense to me.

> - Change
>  BuildRequires: /usr/bin/desktop-file-install
> to
>  BuildRequires: desktop-file-utils
> 
> - You need to conserve time stamps in character set conversion, use 
>  for i in AUTHORS docs/man/{de,es}/*.?; do
>   iconv -f iso-8859-1 -t utf-8 "$i" > "${i}_" && \
>   touch -r "$i" "${i}_" && \
>   mv "${i}_" "$i"
>  done
> This is also safe, since it fails if a command is not completed OK.

Right. Will do.

> - I'm wondering if autoreconfing is really needed; you could just use the trick
> at
>  http://fedoraproject.org/wiki/Packaging/Guidelines#Removing_Rpath

This is due to the new ALSA mixer patch and libtoolize.  I think it's simpler
like this.

> - Why is clean commented out?  

Because I'm an idiot and don't check what I commit carefully. (It's a remain of
debugging the new libtool issue.)

Thanks for your help.  I will incorporate the changes to the spec file, rebuild
and update this bugzilla.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.