[Bug 496635] Review Request: monodevelop-debugger-mdb - Mono Debugger Addin for MonoDevelop

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=496635


Paul Lange <palango at gmx.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|a.badger at gmail.com          |palango at gmx.de




--- Comment #20 from Paul Lange <palango at gmx.de>  2009-06-02 15:20:10 EDT ---
OK Toshio, I'm taking this over.

Mauricio: it's a good practice to try building packages in mock. It looks
difficult at the beginning (I know this from my own experience) but helps you
to create high-quality packages.
For stepping in have a look at
http://fedoraproject.org/wiki/PackageMaintainers/MockTricks

With using mock you'll find out that you need to more build dependencies:
* mono-debugger-devel instead of mono-debugger
* mono-addins-devel

Furthermore I would prefer to adjust the release number to a single number.

The %defattr macro in %files should be %defattr(-,root,root,-)

At the end it would be great if you could split out the *.pc file in a *-devel
package.


The rest looks really good and builds well. If we solve this last errors I'll
do the full review. 
Thanks also to Ryan for creating the fixes!

Paul

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.