[Bug 503810] Review Request: grubby -- Command line tool for updating boot loader configuration file

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=503810


Jason Tibbitts <tibbs at math.uh.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |tibbs at math.uh.edu
               Flag|                            |fedora-review?




--- Comment #2 from Jason Tibbitts <tibbs at math.uh.edu>  2009-06-02 19:47:46 EDT ---
Builds fine and rpmlint is clean.  I thought I'd be able to fall back on the
mkinitrd review, but it hasn't been completed yet and it looks like it has
pretty much the same issues that this one does.  So:

Where does the tarball come from?  I guess it's generated out of git somehow;
if it's really not directly downloadable anywhere, some instructions on
generating it would be good.  See
https://fedoraproject.org/wiki/Packaging:SourceURL

There's a bit of weird formatting in the %description.  I guess someone tried
to fill it with a fixed right margin, so the word spacing is uneven.  Not a
blocker, but I thought I'd mention it.

Really, the source thing is the only issue I see here.

X can't compare source files match upstream.
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK (hopefully soon to go away anyway).
* license field matches the actual license.
* license is open source-compatible.
* license text included in package.
? latest version is being packaged (can't t
* BuildRequires are proper (shouldn't need pkgconfig, but it doesn't hurt).
* compiler flags are appropriate.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly.
* debuginfo package looks complete.
* rpmlint is silent.
* final provides and requires are sane:
   grubby = 6.0.86-1.fc11
   grubby(x86-64) = 6.0.86-1.fc11
  =
   /bin/bash
   /bin/sh
   libblkid.so.1()(64bit)
   libglib-2.0.so.0()(64bit)
   libpopt.so.0()(64bit)

* %check is present and all tests pass:
  120 (100%) tests passed, 0 (0%) tests failed
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no generically named files
* code, not content.
* documentation is small, so no -doc subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no static libraries.
* no libtool .la files.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.