[Bug 498189] Review Request: perl-JavaScript-Minifier-XS - XS based JavaScript minifier

bugzilla at redhat.com bugzilla at redhat.com
Wed Jun 3 03:36:09 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=498189





--- Comment #7 from Chris Weyl <cweyl at alumni.drew.edu>  2009-06-02 23:36:08 EDT ---
Hmm, interesting.  I'm not seeing the "unstripped" warning you described; and
I'm not worried about the "description too long" in the debuginfo package...
not much we could do about that anyways. :)

With apologies for the extremely long delay.

koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=1390386

Spec looks sane, clean and consistent; license is correct (GPL+ or Artistic);
make test passes cleanly.

Source tarballs match upstream (sha1sum):
2f82abee406d893e3938eb29b32f80d7b2b5cd8d JavaScript-Minifier-XS-0.05.tar.gz
2f82abee406d893e3938eb29b32f80d7b2b5cd8d
JavaScript-Minifier-XS-0.05.tar.gz.srpm

Final provides / requires are sane:

0 packages and 1 specfiles checked; 0 errors, 0 warnings.
=====> perl-JavaScript-Minifier-XS-0.05-2.fc12.ppc.rpm <=====
====> rpmlint
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
====> provides for perl-JavaScript-Minifier-XS-0.05-2.fc12.ppc.rpm
perl(JavaScript::Minifier::XS) = 0.05
perl-JavaScript-Minifier-XS = 0.05-2.fc12
perl-JavaScript-Minifier-XS(ppc-32) = 0.05-2.fc12
====> requires for perl-JavaScript-Minifier-XS-0.05-2.fc12.ppc.rpm
libc.so.6  
libc.so.6(GLIBC_2.0)  
libc.so.6(GLIBC_2.1.3)  
libc.so.6(GLIBC_2.3)  
perl >= 0:5.006
perl(DynaLoader)  
perl(Exporter)  
perl(:MODULE_COMPAT_5.10.0)  
perl(strict)  
perl(warnings)  
rtld(GNU_HASH)  

=====> perl-JavaScript-Minifier-XS-0.05-2.fc12.src.rpm <=====
====> rpmlint
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
====> provides for perl-JavaScript-Minifier-XS-0.05-2.fc12.src.rpm
====> requires for perl-JavaScript-Minifier-XS-0.05-2.fc12.src.rpm
perl(JavaScript::Minifier)  
perl(Module::Build)  
perl(Test::More)  
perl(Test::Pod)  

=====> perl-JavaScript-Minifier-XS-debuginfo-0.05-2.fc12.ppc.rpm <=====
====> rpmlint
perl-JavaScript-Minifier-XS-debuginfo.ppc: E: description-line-too-long This
package provides debug information for package perl-JavaScript-Minifier-XS.
1 packages and 0 specfiles checked; 1 errors, 0 warnings.
====> provides for perl-JavaScript-Minifier-XS-debuginfo-0.05-2.fc12.ppc.rpm
perl-JavaScript-Minifier-XS-debuginfo = 0.05-2.fc12
perl-JavaScript-Minifier-XS-debuginfo(ppc-32) = 0.05-2.fc12
====> requires for perl-JavaScript-Minifier-XS-debuginfo-0.05-2.fc12.ppc.rpm

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list