[Bug 503967] Review Request: mobile-broadband-provider-info - database of mobile broadband providers

bugzilla at redhat.com bugzilla at redhat.com
Wed Jun 3 18:16:52 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=503967


Warren Togami <wtogami at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |wtogami at redhat.com




--- Comment #1 from Warren Togami <wtogami at redhat.com>  2009-06-03 14:16:51 EDT ---
Version: 20090602

Will this always be versioned by the date?  Perhaps "0.20090602" might be
better to allow for real version numbers in the future without Epoch?

BuildRoot: %(mktemp -ud %{_tmppath}/%{name}-%{version}-%{release}-XXXXXX)

This isn't even used by modern rpmbuild.  Doesn't need to be so complicated.

ExclusiveArch: noarch

Please use "BuildArch: noarch" instead, except the next problem...

[warren at newcaprica noarch]$ rpmlint
mobile-broadband-provider-info-20090602-1.fc11.noarch.rpm 
mobile-broadband-provider-info.noarch: W: devel-file-in-non-devel-package
/usr/lib64/pkgconfig/mobile-broadband-provider-info.pc

This is a serious problem.  Note the lib64 dir.  Perhaps you can't make this
noarch if you want to use pkgconfig?

[warren at newcaprica SRPMS]$ rpmlint
mobile-broadband-provider-info-20090602-1.fc11.src.rpm 
mobile-broadband-provider-info.src:25: W: make-check-outside-check-section make
check
mobile-broadband-provider-info.src:38: W: libdir-macro-in-noarch-package (main
package) %attr(0644,root,root) %{_libdir}/pkgconfig/%{name}.pc

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list