[Bug 502622] Review Request: perl-Config-Properties - Read and write property files
bugzilla at redhat.com
bugzilla at redhat.com
Wed Jun 3 20:42:40 UTC 2009
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=502622
--- Comment #1 from Jason Tibbitts <tibbs at math.uh.edu> 2009-06-03 16:42:39 EDT ---
Builds fine; rpmlint is silent.
FYI, I agree that conditionally running a test depending on the name of the
user running it is dumb and needs to be patched out.
I can see why this would require Test::More at runtime. It doesn't appear
anywhere in the final package (save the Changelog, where it talks about the
test suite).
* source files match upstream. sha256sum:
afb0e7a20a95f0e8004296fdecd1c320ec7d296cbdb5ce7bbc0a1f75266d7e84
Config-Properties-1.70.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text not included upstream.
* latest version is being packaged.
* BuildRequires are proper.
* compiler flags are appropriate.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly.
* rpmlint is silent.
? final provides and requires are sane:
perl(Config::Properties) = 1.70
perl-Config-Properties = 1.70-1.fc11
=
perl(:MODULE_COMPAT_5.10.0)
perl(Carp)
perl(IO::Handle)
? perl(Test::More)
perl(strict)
perl(warnings)
* %check is present and all tests pass:
All tests successful.
Files=7, Tests=52, 1 wallclock secs ( 0.05 usr 0.02 sys + 0.31 cusr 0.07
csys = 0.45 CPU)
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no generically named files
* code, not content.
* documentation is small, so no -doc subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the Fedora-package-review
mailing list