[Bug 503519] Review Request: bastet - An evil falling bricks game

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=503519


Tom "spot" Callaway <tcallawa at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|182235(FE-Legal)            |
         AssignedTo|nobody at fedoraproject.org    |tcallawa at redhat.com
               Flag|                            |fedora-review?




--- Comment #5 from Tom "spot" Callaway <tcallawa at redhat.com>  2009-06-04 09:10:26 EDT ---
Trademark stuff looks good now, thanks.

A few other issues that need to be resolved:

* The License: should be GPLv3+ (look at the code headers).
* You're also not building it with %{optflags}. (passing CXXFLAGS="%{optflags}"
to make should do the trick)
* You're also using the old icon cache scriptlets, see:
https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#Icon_Cache
* You do not need to manually gzip the manpage, just install it uncompressed
into the proper mandir and rpm will gzip it properly for you.

I think that fixing those items should be enough for me to finish the review.
Lifting FE-Legal.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.