[Bug 502693] Review Request: Elgg 1.5 - An open source social networking platform.

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=502693





--- Comment #3 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp>  2009-06-06 15:36:57 EDT ---
Only commenting for the previous comments (I have not
checked the srpm from the submitter itself)

(In reply to comment #1)
> Legend:
> +: OK
> -: not ok, see  notes
> N: Not applicable
> ?: Not sure, please comment
>  
> ? MUST: The package must meet the Packaging Guidelines .
> Specfile does not define buildroot, is that ok?
- This can be ignored
  (on rpm 4.4.X BuildRoot in spec file defines %buildroot.
   on rpm 4.6+ BuildRoot is completely ignored and %buildroot
   is defined automatically)

> - MUST: A Fedora package must not list a file more than once in the spec file's
> %files listings. [13]
> 
> Don't know why this happens, nut buildlog says: warning: File listed twice:
> /usr/share/elgg/.htaccess
> I asssume this is caused by the fact that you list both the file itself AND
> %{elggdir}

- Actually when the spec file contains
--------------------------------------------------
%files
foo/
--------------------------------------------------
  (where foo is a directory) this contains the directory
  foo itself and all files/directories/etc under foo/. 

By the way, at least please specify full URL for Source0:
https://fedoraproject.org/wiki/Packaging/SourceURL

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.