[Bug 503256] Review Request: gtkmm-utils - C++ utility and widget library based on glibmm and gtkmm

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=503256





--- Comment #32 from Jussi Lehtola <jussi.lehtola at iki.fi>  2009-06-07 05:24:14 EDT ---
- Fix the tabbing on the BuildRequires line.

rpmlint output:
gtkmm-utils.x86_64: E: binary-or-shlib-defines-rpath
/usr/lib64/libgtkmm-utils.so.2.0.0 ['/usr/lib64']
gtkmm-utils-example.x86_64: W: only-non-binary-in-usr-lib
gtkmm-utils-example.x86_64: W: no-documentation
6 packages and 0 specfiles checked; 1 errors, 2 warnings.

- You will need to fix the rpath problem with
 sed -i 's|^hardcode_libdir_flag_spec=.*|hardcode_libdir_flag_spec=""|g'
libtool
 sed -i 's|^runpath_var=LD_RUN_PATH|runpath_var=DIE_RPATH_DIE|g' libtool
after %configure. 
( http://fedoraproject.org/wiki/Packaging /Guidelines#Removing_Rpath )

- Add comments to %install phase, e.g.

%install                                                                       
rm -rf $RPM_BUILD_ROOT
make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p"
find $RPM_BUILD_ROOT -name '*.la' -exec rm -f {} ';'

# Remove object files from examples going into %doc
rm -rf examples/.deps/ examples/.libs examples/*.o examples/Makefile*

# Fix incorrect permissions
chmod 755 $RPM_BUILD_ROOT{_libdir}/*.so.*

# Install compiled examples into %{_libdir}/%{name}
mkdir -p $RPM_BUILD_ROOT%{_libdir}/%{name}/
mv examples/{logging,multi-completion,tiles-simple}
$RPM_BUILD_ROOT%{_libdir}/%{name}/


- Put the examples/ in the %doc of the -examples package, not in -devel.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.