[Bug 495412] Review Request: flamerobin - Graphical client for Firebird

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=495412





--- Comment #16 from Peter Lemenkov <lemenkov at gmail.com>  2009-06-07 06:28:46 EDT ---
Notes:

* Use full patch for Source0:

http://dfn.dl.sourceforge.net/sourceforge/flamerobin/flamerobin-0.9.2-src.tar.gz

* remove --mandir explicit parameter passing (%configure already makes it)

* change %makeinstall to "make install DESTDIR=$RPM_BUILD_ROOT"

* this line is not needed at all "mkdir -p
%{buildroot}/%{_datadir}/applications"

Other things looks sane. Here is a koji scratch build withall these changes:

http://koji.fedoraproject.org/koji/taskinfo?taskID=1397625

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.