[Bug 499579] Review Request: libxdg-basedir - Implementation of the XDG Base Directory Specifications

bugzilla at redhat.com bugzilla at redhat.com
Tue Jun 9 09:06:49 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=499579





--- Comment #5 from Michal Nowak <mnowak at redhat.com>  2009-06-09 05:06:48 EDT ---
(In reply to comment #4)

Hola, thanks for the review.

Re:
"""
Ok, good! Only one small request: please can you rename the -docs package into
-doc? I'm not 100% sure about this because I've found on my system packages
with both naming conventions. However, the packaging guidelines only mention
-doc: 
http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation
"""

Correct. I misread the docs. Corrected.

Re:
"""
Sorry, probably there was a small misunderstanding here. Adding "Requires:
pkgconfig" is sufficient since it will provide the ownership of
%{_libdir}/pkgconfig. So it is not needed that libxdg-base-devel owns the
pkgconfig directory itself (and other packages with *.pc files don't do it
either... ;-) ).
"""

Yep. Right. I should use brain next time.

Both issues fixed:

* Tue Jun  9 2009 Michal Nowak <mnowak at redhat.com> - 1.0.1-2
- removed bogus ownership of %%{_libdir}/pkgconfig/
- "docs" sub-package renamed to "doc"


http://mnowak.fedorapeople.org/libxdg-basedir/libxdg-basedir.spec
http://mnowak.fedorapeople.org/libxdg-basedir/libxdg-basedir-1.0.1-2.fc11.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list