[Bug 485652] Review Request: navit - Car navigation system with routing engine

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=485652





--- Comment #8 from Fabian Affolter <fabian at bernewireless.net>  2009-06-10 16:30:58 EDT ---
(In reply to comment #5)
> The spec contributed by Fabian is clearly based on my Mandriva spec (see, for
> comparison,
> http://svn.mandriva.com/cgi-bin/viewvc.cgi/packages/cooker/navit/current/SPECS/navit.spec?view=markup
> ) - it would have been polite to acknowledge this in the submission, Fabian.

Yes, your spec file provides some lines to the Fedora spec file, especially the
patches.  

(In reply to comment #6)
> forgot to mention, mine has some improvements over Fabian's, like dropping .la
> files.

In my spec file the following line takes care about the .la files
find %{buildroot} -name '*.la' -exec rm -f {} ';'

as suggest in the Packaging guidelines.

(In reply to comment #7)
> btw, I think the -devel package is bogus...the 'libraries' are just plugins,
> they shouldn't have been installed as shared libraries by navit in the first
> place. they should only contain .so files (not .so.0.0.0 and .so.0) and these
> should be in the main package(s).

It's good to have versioned plugins ;-) I agree that they should go in the main
packages.

> I don't know why Fabian removed the split of different rendering engines from
> my package. The reason they were split is to reduce dependencies - if you roll
> them all together, as Fabian did, you have to have libqt4 installed to install
> navit even if you have no intention of ever using the QT renderer. ditto cegui
> etc.

I can't remember why I did this...perhaps the reason is simple: Just
misremember. My spec file is still in an early stage (see %file section). The
intention was to build a working prototype and then do the cleaning.

Aout the map: I personally see no reason to include a sample map because this
blow the package size up and have only gain for a few users.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.