[Bug 500746] Review Request: 389-admin - renamed from fedora-ds-admin

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=500746





--- Comment #11 from Rich Megginson <rmeggins at redhat.com>  2009-06-17 16:52:14 EDT ---
(In reply to comment #10)
> Bad:
> - I have found source files which state GPLv2+ or AL 2.0 as
>   license. Please clarify the stated license on the license tag
> - Package only contains the LICENSE file, but the COPYING file,
>   which contains the verbatin text of the GPLv2 is not included
> - Usage of the %{_initrddir} macro is obsoleted

- all of the files in the adminserver (except the Apache modules) should have
been gplv2 - this has been fixed, including the LICENSE file
- there are two Apache modules included with the admin server that are licensed
under the apl 2.0 - mod_admserv and mod_restartd - these must use the apl
because they use apl code - how should I denote this?
- fixed _initrddir

> - Why do you set the owner/permission of some files explicitly in the
>   %post scriptlet?

There is a "bug" or perhaps it is a feature of rpm that it does not preserve
the ownership/permissions of files/directories marked config noreplace.  These
are files and directories which users are accustomed to changing.  If we do not
explicitly save and preserve the owner/permission in pre/post, upgrade will
break existing installations.  I know it is somewhat of a hack, but this is the
only way I could get it to work.  Suggestions are welcome.

> - warning from rpmlint about source rpm.
>    rpmlint 389-admin-1.1.7-5.fc11.src.rpm
>    389-admin.src: W: strange-permission 389-admin-git.sh 0775

- fixed

> - Warnings from rpmlint about the binary rpm
>    $ rpmlint 389-admin-1.1.7-5.fc11.x86_64.rpm
>    389-admin.x86_64: W: dangerous-command-in-%post chmod
>    389-admin.x86_64: W: incoherent-init-script-name dirsrv-admin  

- the init script and service name are dirsrv-admin - this was a conscious
decision not to tie it to the package name

new SRPM: http://rmeggins.fedorapeople.org/pkgreview/389-admin-1.1.7-5.src.rpm
new Spec: http://rmeggins.fedorapeople.org/pkgreview/389-admin.spec
new Source URL: http://port389.org/sources/389-admin-1.1.7.tar.bz2
md5sum 389-admin-1.1.7.tar.bz2 
1844088cbe44bc9eda371ce606a38405  389-admin-1.1.7.tar.bz2
sha1sum 389-admin-1.1.7.tar.bz2
e6f9beea076220f485aa93c990935dd0134a18da  389-admin-1.1.7.tar.bz2

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.