[Bug 506712] Package Review: libccss - A simple api for CSS Stylesheets

bugzilla at redhat.com bugzilla at redhat.com
Thu Jun 18 17:09:19 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=506712


Peter Robinson <pbrobinson at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pbrobinson at gmail.com




--- Comment #2 from Peter Robinson <pbrobinson at gmail.com>  2009-06-18 13:09:18 EDT ---
> This time I looked through the source files and they all have the "or (at your
> option) any later version" variety, which in my understanding makes the package
> LGPLv2+ .

Updated in my local ver

> URL: http://cgit.freedesktop.org/ccss/ 
> or
> URL: http://people.freedesktop.org/~robsta/libccss/

Have used the later for the moment. It seems from comments that it will
eventually be all on freedesktop.org so will update it as it channges

> BuildRequires: gtk-doc
> is not really necessary, the tarball has the docs already built.
> 
> The last paragraph of the description seems out of place (everything after the
> bullet points) . Perhaps just remove it.
> 
> You could add --disable-examples to spare few cycles.
> 
> There is a TODO file that looks to be maintained.

Done

> You could 
> %{_includedir}/libccss-1
> and be done with it. If the package is not split on cairo/gtk etc. there is
> hardly a point in listing everything.

I've done it that way mainly so I see if there's any changes by a broken build
:-)

> Other than the license, all minor concerns. I believe you'll fix that prior to
> import. APPROVED.

Thanks!

> Again as with rest some head scratching on weather it should be called libccss
> or ccss , but I like the idea of sticking with the tarball name best. And its
> just a library.  

So did I but I figured that as the tarball was libccss I would use that to
follow conventions.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list