[Bug 506887] Review Request: perl-CGI-Application-Plugin-AutoRunmode - CGI::App plugin to automatically register runmodes

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=506887


Parag AN(पराग) <panemade at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




--- Comment #3 from Parag AN(पराग) <panemade at gmail.com>  2009-06-19 05:09:49 EDT ---
Review:
+ package builds in mock (rawhide i586).
koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1424569
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
ee2a03edd1a6d3590cad31db733af9c32dd45d12 
CGI-Application-Plugin-AutoRunmode-0.16.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
All tests successful.
Files=8, Tests=71,  0 wallclock secs ( 0.04 usr  0.01 sys +  0.41 cusr  0.05
csys =  0.51 CPU)
+ Package  perl-CGI-Application-Plugin-AutoRunmode-0.16-2.fc12.noarch =>
Provides: perl(CGI::Application::Plugin::AutoRunmode) = 0.16
perl(CGI::Application::Plugin::AutoRunmode::FileDelegate) = 0.13
Requires: perl(CGI::Application) perl(Carp) perl(Exporter) perl(strict)
+ Not a GUI application

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.