[Bug 507061] Review Request: perl-CGI-Application-Plugin-Stream - CGI::Application Plugin for streaming files

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=507061


Parag AN(पराग) <panemade at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




--- Comment #1 from Parag AN(पराग) <panemade at gmail.com>  2009-06-22 01:45:09 EDT ---
Review:
+ package builds in mock (rawhide i586).
koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1428530
- rpmlint is silent for SRPM and for RPM.
perl-CGI-Application-Plugin-Stream.noarch: W: incoherent-version-in-changelog
2.06-1 ['2.10-1.fc12', '2.10-1']
==> fix this
+ source files match upstream url
78cca2cefe005f59c440a362c4cbeeaa12cf115b 
CGI-Application-Plugin-Stream-2.10.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
All tests successful.
Files=3, Tests=16,  0 wallclock secs ( 0.01 usr  0.02 sys +  0.30 cusr  0.04
csys =  0.37 CPU)
+ Package perl-CGI-Application-Plugin-Stream-2.10-1.fc12.noarch =>
Provides: perl(CGI::Application::Plugin::Stream) = 2.10
Requires: perl >= 0:5.006 perl(CGI::Application) >= 3.21 perl(Exporter)
perl(File::Basename) perl(strict) perl(vars) perl(warnings)
+ Not a GUI application

Suggestions:
1) Fix changelog entry before cvs import.
2) You need to 
Requires: perl(File::MMagic), not picked up by yum.
APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.