[Bug 507475] Review Request: skanlite - Scanning program

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=507475





--- Comment #5 from Sven Lankes <sven at lank.es>  2009-06-23 18:13:54 EDT ---
(In reply to comment #3)

Thanks for looking at the package.

An updated package is availabe at:

Spec URL: http://sven.lank.es/Fedora/SPECS/skanlite.spec
SRPM URL: http://sven.lank.es/Fedora/SRPM/skanlite-0.3-2.fc11.src.rpm

> - Use %global instead of %define, see
> https://fedoraproject.org/wiki/PackagingDrafts/global_preferred_over_define

Fixed

> - Timestamp of Source0 does not match, see
> https://fedoraproject.org/wiki/Packaging/Guidelines#Timestamps

Fixed

> - Do not use macros for %{__rm}, simply rm is ok

Fixed

> - Add TODO to %doc

Not sure it adds any value for a user but still: Fixed

> - Remove --vendor="" from desktop-file-install

Fixed

> - Mark the docs as %doc (although rpm should be smart enough to do this
> automatically).

Fixed

> - Remove the empty common symlinks or make them point to something that is
> actually there, as Mamoru already said in bug 479147.

Not fixed - please see bug 491247. This is a general issue for all
kde-packages - my /usr/share/HTML-directory has 117 dangling common-symlinks
currently.

The only "valid" fix I can think of here is removing the HTML-Documentation
altogether and I would rather not do that.

> Notes:
> - The summary is a little weak. How about "Lightweight scanning program for
> KDE"?

Hmm - I've added lightweight. Adding "for KDE" doesn't really add any value to
the summary IMO.

> - Use wildcarts for the Languages in the documentation:
>   %{_kde4_docdir}/HTML/*/skanlite/

Done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.