[Bug 504710] Review Request: rubygem-gettext_rails - Localization support for Ruby on Rails(>=2.3) by Ruby-GetText-Package

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=504710


Xavier Lamien <lxtnow at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




--- Comment #3 from Xavier Lamien <lxtnow at gmail.com>  2009-06-25 17:49:48 EDT ---
OK source files match upstream
OK package meets naming and versioning guidelines.
OK specfile is properly named, is cleanly written and uses macros consistently.
OK dist tag is present.
OK      Global are used.
OK build root is correct.
OK license field matches the actual license.
OK license is open source-compatible (LGPLv2 or Ruby). License text included in
package in part of reason has been given properly.
OK latest version is being packaged.
OK BuildRequires are proper.
OK %clean is present.
OK package builds in koji (Rawhide/x86_64).
OK rpmlint is silent.
OK final provides and requires look sane.
-- %check is present (however, test need more work, not a blocker).
OK owns the directories it creates.
OK doesn't own any directories it shouldn't.
OK no duplicates in %files.
OK file permissions are appropriate.
OK correct scriptlets present.
OK code, not content.
OK huge %docs has been moved to sub-package 
OK      package installed properly

According to ruby guideline, the package uses proper ruby specific packaging.


** APPROVED **

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.