[Bug 507703] Review Request: perl-Proc-Simple - Launch and control background processes

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=507703





--- Comment #4 from Lubomir Rintel <lkundrak at v3.sk>  2009-06-26 10:31:16 EDT ---
(In reply to comment #3)
> Jan Klepek
> 
> 1) In my opinion, you maybe need to correct %file section. Because
> %{perl_vendorlib}/Proc would be owned by another packages like perl-Proc-*.
> 
> I think these are better.
> 
> %files
> %defattr(-,root,root,-)
> %doc Changes README
> %{perl_vendorlib}/Proc/*
> %{_mandir}/man3/*

This is not right -- that would leave an unowned %{perl_vendorlib}/Proc upon
removal of the package, which violates the guidelines. Sharing directories is
completely fine. Jan, please don't change that.

> 2) That BuildArch is noarch seems not to be suitable for it. As I see, building
> package for various architectures may be better than noarch. So I advise that
> BuildArch should be removed.  

Wrong. There's nothing arch-specific in the package; it's definitely noarch.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.