[Bug 508453] Review Request: rubygem-test-spec - Behaviour Driven Development interface for Test::Unit

bugzilla at redhat.com bugzilla at redhat.com
Sun Jun 28 12:52:48 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=508453





--- Comment #1 from Michal Ingeli <mi at v3.sk>  2009-06-28 08:52:47 EDT ---
* naming ok
* spec file clean, american english
* file lists ok, examples in documentation
* builds in mock
* rpmlint silent
* source matches upstream

work to do:
- package is distributed in the same terms as ruby is. So it should have ruby
license or GPLv2. Not GPLv2+.
- Consistent build root reference. In %clean stare it's referred to build root
as %{buildroot} and other stages uses $RPM_BUILD_ROOT.
- add BuildRequires: ruby(abi) = 1.8 (maybe should be checked by rpmlint)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list