[Bug 507410] Review Request: yum-download-order - Yum plugin to order downloading of packages

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=507410


Sergio Pascual <sergio.pasra at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-review?




--- Comment #7 from Sergio Pascual <sergio.pasra at gmail.com>  2009-06-29 18:23:11 EDT ---
Rakesh, the tarball upstream doesn't match the source in rpm. Please upload the
new tarball so that I can write the review.

Other things:

 * why do you need python-setuptools-devel?, python-setuptools is enough to
build and install most python applications.
 * the current recommended macro for python_sitelib is:

%{!?python_sitelib: %global python_sitelib %(%{__python} -c "from
distutils.sysconfig import get_python_lib; print get_python_lib()")}

 just change define by global http://fedoraproject.org/wiki/Packaging:Python

 * download-order.py has a shebang in the first line. As this file isn't a
script
   intended to be run by users, I think its better to remove it (when we also
remove a rpmlint error)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.