[Bug 508817] Review Request: Limesurvey - An open source survey application

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=508817





--- Comment #2 from Ian Weller <ian at ianweller.org>  2009-06-30 12:11:05 EDT ---
Source URL: Please read
https://fedoraproject.org/wiki/Packaging/SourceURL#Sourceforge.net for dealing
with Source0's URL properly. (Note you can't use %{name}-%{version}.whatever
because the package is WHOAAAAAcompletely different.)

Macros: Those look like the Zikula-specific macros at the top and in reality
they aren't really helping all that much. One is redundant, and it would be
much cleaner in the specfile to just type out "limesurvey" and %{_datadir} so
people don't get lost.

(On the same note, having files under /usr/share/limesurvey/limesurvey seems
mildly redundant and probably shouldn't be done.)

Requires: Are you supposed to require a webserver? Check with somebody on that
and paste the IRC log (or whatever) here.

rpmlint: is very loud. Output will be attached. The gist of it is
"file-not-in-%lang" warnings; take a look at
https://fedoraproject.org/wiki/Packaging:Guidelines#Handling_Locale_Files

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.