[Bug 486698] Review Request: fedora-setup-keyboard - Hal keyboard layout callout

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=486698


Jens Petersen <petersen at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |petersen at redhat.com
               Flag|                            |fedora-review+




--- Comment #8 from Jens Petersen <petersen at redhat.com>  2009-03-01 19:23:12 EDT ---
Apologies for the slow response - somehow missed your updates in my bugzilla
folder last week.

Thanks for the update.  Here is my review:

 +:ok, !:needs fixing

MUST Items:
[+] MUST: rpmlint output

rpmlint is now clean. :)

[*] MUST: Package Naming Guidelines
[+] MUST: spec file name must match base package %{name}
[+] MUST: Packaging Guidelines.
[+] MUST: Licensing Guidelines
[!] MUST: License field in the package spec file must match actual license.

The license is MIT not BSD!

[+] MUST: include license files in %doc if available in source
[+] MUST: The spec file must be written in American English and be legible.
[+] MUST: source md5sum matches upstream release

6bcb3d6a9f31eddd69aac5df3b50dd98  fedora-setup-keyboard-0.3.tar.bz2

[+] MUST: must successfully compile and build into binary rpms on one main arch
[+] MUST: All build dependencies must be listed in BuildRequires
[no shared libs]
[+] MUST: A package must own all directories that it creates.
[+] MUST: A package must not contain any duplicate files in the %files listing.
[+] MUST: Permissions on files must be set properly.
[+] MUST: Each package must have a %clean section, which contains rm -rf
%{buildroot} (or $RPM_BUILD_ROOT).
[+] MUST: Each package must consistently use macros
[+] MUST: The package must contain code, or permissable content.
[+] MUST: If a package includes something as %doc, it must not affect the
runtime of the application.
[no devel files]
[+] MUST: Packages must not own files or directories already owned by other
packages.
[+] MUST: At the beginning of %install, each package MUST run rm -rf
%{buildroot} (or $RPM_BUILD_ROOT).
[+] MUST: All filenames in rpm packages must be valid UTF-8.

SHOULD Items:
[+] SHOULD: If the source package does not include license text(s) as a
separate file from upstream, the packager SHOULD query upstream to include it.
[+] SHOULD: The reviewer should test that the package builds in mock.

http://koji.fedoraproject.org/koji/taskinfo?taskID=1212001

[+] SHOULD: The package should compile and build into binary rpms on all
supported architectures.


Please be sure to fix the License field before importing and
the package is APPROVED for inclusion in Fedora.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.