[Bug 487067] Review Request: autopsy - Graphical front end for The Sleuth Kit Forensics software

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=487067


Suravee Suthikulpanit <suravee.suthikulpanit at amd.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |suravee.suthikulpanit at amd.c
                   |                            |om




--- Comment #1 from Suravee Suthikulpanit <suravee.suthikulpanit at amd.com>  2009-03-02 16:00:28 EDT ---
This is an unofficial review.

- rpmlint -iv /root/rpmbuild/RPMS/noarch/autopsy-2.21-1.fc10.noarch.rpm 
autopsy.noarch: I: checking
autopsy.noarch: W: log-files-without-logrotate /var/log/autopsy
This package contains files in /var/log/ without adding logrotate
configuration for them.

autopsy.noarch: E: file-in-usr-marked-as-conffile /usr/share/autopsy/conf.pl
A file in /usr is marked as being a configuration file. Store your conf files
in /etc/ instead.

autopsy.noarch: E: file-in-usr-marked-as-conffile
/usr/share/autopsy/lib/define.pl
A file in /usr is marked as being a configuration file. Store your conf files
in /etc/ instead.

1 packages and 0 specfiles checked; 2 errors, 1 warnings.


- Source0 has typo.
Original
http://download.sourceforge.net/autopsy/%{name}-%{version}.tar.gz
Should be
http://downloads.sourceforge.net/autopsy/%{name}-%{version}.tar.gz

- Build has warning:
    warning: File listed twice: /usr/share/autopsy/conf.pl
    warning: File listed twice: /usr/share/autopsy/lib/define.pl

- Installation failed
rpm -Uvh ~/rpmbuild/RPMS/noarch/autopsy-2.21-1.fc10.noarch.rpm 
error: Failed dependencies:
        perl(Main) is needed by autopsy-2.21-1.fc10.noarch
        perl(conf.pl) is needed by autopsy-2.21-1.fc10.noarch
        perl(define.pl) is needed by autopsy-2.21-1.fc10.noarch
        perl(lib::define.pl) is needed by autopsy-2.21-1.fc10.noarch
        perl(search.pl) is needed by autopsy-2.21-1.fc10.noarch


RECOMMENDS:
- Please see http://fedoraproject.org/wiki/Packaging/Perl

- Typo at the end of %description ("documentatio.n")

- In %install, instead of 
    install -d %{buildroot}%{_sbindir}
    install -m0755 autopsy %{buildroot}%{_sbindir}/autopsy
uses
    install -D -m0755 autopsy %{buildroot}%{_sbindir}/autopsy

- In %files, may I suggest the following:
    %defattr(-,root,root,-)
    %doc CHANGES.txt COPYING docs/*.txt INSTALL.txt README-LIVE.txt README.txt
TODO.txt
    %dir %{_datadir}/autopsy
    %{_datadir}/autopsy/*
    %{_sbindir}/autopsy
    %{_sbindir}/make-live-cd
    %dir /var/log/autopsy
    %dir %{_localstatedir}/lib/morgue
    %{_mandir}/man1/*


OKAYS:
- Match latest upstream code
835938086e4ebec628408faa624c48927f261b7df4eeb2b041a293867ba79f5f 
autopsy-2.21.tar.gz
835938086e4ebec628408faa624c48927f261b7df4eeb2b041a293867ba79f5f 
/root/rpmbuild/SOURCES/autopsy-2.21.tar.gz

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.