[Bug 488035] Review Request: tigervnc - A TigerVNC remote display system - rename from TightVNC

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=488035





--- Comment #1 from Dan Horák <dan at danny.cz>  2009-03-03 15:15:20 EDT ---
formal review is here, see the notes below:

OK source files match upstream (no difference between the included archive and
fresh svn checkout):
     7957167797dd10c5f3542dab4aaa25834aab41ec 
tigervnc-0.0.90-20090302svn3621.tar.bz2
OK package meets naming and versioning guidelines.
OK specfile is properly named, is cleanly written and uses macros consistently.
OK dist tag is present.
OK license field matches the actual license.
OK license is open source-compatible (GPLv2+). License text included in
package.
OK latest version is being packaged.
OK BuildRequires are proper.
OK compiler flags are appropriate.
OK %clean is present.
OK package builds in mock (Rawhide/x86_64).
OK debuginfo package looks complete.
OK* rpmlint is silent.
OK final provides and requires look sane.
N/A %check is present and all tests pass.
OK no shared libraries are added to the regular linker search paths.
OK owns the directories it creates.
OK doesn't own any directories it shouldn't.
OK no duplicates in %files.
OK file permissions are appropriate.
OK* correct scriptlets present.
OK code, not content.
OK documentation is small, so no -docs subpackage is necessary.
OK %docs are not necessary for the proper functioning of the package.
OK no headers.
OK no pkgconfig files.
OK no libtool .la droppings.
OK* is GUI app, desktop file is present

- rpmlint complains a bit
tigervnc-server-module.x86_64: W: no-documentation
 => OK
tigervnc-server-module.x86_64: W: filename-too-long-for-joliet
tigervnc-server-module-0.0.90-0.1.20090302svn3621.fc11.x86_64.rpm
 => OK
tigervnc-server.x86_64: W: incoherent-init-script-name vncserver
 => OK
tigervnc.src: W: mixed-use-of-spaces-and-tabs (spaces: line 18, tab: line 1)
 => please fix

- there is new version of "icon-cache" scriptlets approved (IIRC), but not yet
moved from Drafts, so keep the current one
- drop "--vendor fedora" when install the desktop file
- you can include unix/README as %doc, it contains some acknowledgments that
would be nice to distribute

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.