[Bug 488444] Review Request: perl-MooseX-Singleton - Turn your Moose class into a singleton

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=488444


Parag AN(पराग) <panemade at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




--- Comment #1 from Parag AN(पराग) <panemade at gmail.com>  2009-03-04 08:18:20 EDT ---
Review:
+ package builds in mock (rawhide i386).
koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1219852
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
2e1aefa342d4d73bd8ff6fe2ab0ab34e  MooseX-Singleton-0.14.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
All tests successful.
Files=3, Tests=42,  1 wallclock secs ( 0.03 usr  0.01 sys +  1.34 cusr  0.07
csys =  1.45 CPU)
+ Package perl-MooseX-Singleton-0.14-1.fc11-noarch =>
Provides: perl(MooseX::Singleton) = 0.14 perl(MooseX::Singleton::Meta::Class)
perl(MooseX::Singleton::Meta::Instance)
perl(MooseX::Singleton::Meta::Method::Constructor)
perl(MooseX::Singleton::Object)
Requires: perl(Moose) perl(Moose::Exporter) perl(Scalar::Util) perl(metaclass)

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.