[Bug 488919] Review Request: perl-App-Cache - Easy application-level caching

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=488919


Parag AN(पराग) <panemade at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




--- Comment #1 from Parag AN(पराग) <panemade at gmail.com>  2009-03-06 03:25:33 EDT ---
Review:
+ package builds in mock (rawhide i386).
koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1225790
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
3483ed94401531d16ceab63d57b8da6e  App-Cache-0.35.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
All tests successful.
Files=3, Tests=41,  6 wallclock secs ( 0.00 usr  0.01 sys +  0.41 cusr  0.05
csys =  0.47 CPU)
+ package perl-App-Cache-0.35-1.fc11-noarch =>
  Provides: perl(App::Cache) = 0.35
  Requires: perl(File::Find::Rule) perl(File::HomeDir) perl(File::stat)
perl(HTTP::Cookies) perl(LWP::UserAgent) perl(Path::Class) perl(Storable)
perl(base) perl(strict)

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.