[Bug 479874] Review Request: mingw32-postgresql - postgresql development library's libpq

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=479874


Tom "spot" Callaway <tcallawa at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tcallawa at redhat.com




--- Comment #4 from Tom "spot" Callaway <tcallawa at redhat.com>  2009-03-06 14:22:24 EDT ---
I started trying to do this review, but I kept tripping over things:

- Package uses %{_mingw32_libdir}/*, see:
http://fedoraproject.org/wiki/Packaging/MinGW#Do_not_use_.25.7B_mingw32_bindir.7D.2F.2A_or_.25.7B_mingw32_libdir.7D.2F.2A_in_.25files_section

- Spec is missing correct BuildRequires (see Comment #3)
- Package contains static libraries:
/usr/i686-pc-mingw32/sys-root/mingw/lib/libecpg.a
/usr/i686-pc-mingw32/sys-root/mingw/lib/libecpg_compat.a
/usr/i686-pc-mingw32/sys-root/mingw/lib/libpgport.a
/usr/i686-pc-mingw32/sys-root/mingw/lib/libpgtypes.a
/usr/i686-pc-mingw32/sys-root/mingw/lib/libpostgres.a
/usr/i686-pc-mingw32/sys-root/mingw/lib/libpq.a

See: http://fedoraproject.org/wiki/Packaging/MinGW#Static_libraries

- Not in sync with rawhide (8.3.6 vs 8.3.5).
- Normal postgresql is carrying six patches not found here:
Patch1: rpm-pgsql.patch
Patch2: postgresql-ac-version.patch
Patch3: postgresql-logging.patch
Patch4: postgresql-test.patch
Patch5: pgtcl-no-rpath.patch
Patch6: postgresql-perl-rpath.patch
- Built with an entirely different set of configure options

I am very uncomfortable with this package as is. I'd really prefer if someone
like Tom Lane did the review here.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.