[Bug 478749] Review Request: dinotrace - X11 waveform viewer for electronics

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=478749


manuel wolfshant <wolfy at nobugconsulting.ro> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|wolfy at nobugconsulting.ro    |
         AssignedTo|nobody at fedoraproject.org    |wolfy at nobugconsulting.ro
               Flag|                            |fedora-review?




--- Comment #12 from manuel wolfshant <wolfy at nobugconsulting.ro>  2009-03-07 12:59:18 EDT ---
I'll come back with a full review next week, once I get the chance to install
the application at a colleague and test it.

meanwhile, Chitlesh, could you please take a look at the patch (at the first
glance I think it has a couple of places where a line is replaced with
uselessly replaced with an identical copy) and maybe fix the warnings related
to emacs which appear during building the package in mock:

Loading /usr/share/emacs/site-lisp/site-start.d/rpm-spec-mode-init.el
(source)...
In toplevel form:
dinotrace.el:165:1:Warning: defface for `dinotrace-foreground-face' fails to
    specify containing group
In dinotrace-annotate-buffer:
dinotrace.el:694:14:Warning: `make-variable-buffer-local' should be called at
    toplevel
dinotrace.el:690:42:Warning: `make-variable-buffer-local' should be called at
    toplevel
dinotrace.el:691:68:Warning: `make-variable-buffer-local' should be called at
    toplevel
dinotrace.el:692:74:Warning: `make-variable-buffer-local' should be called at
    toplevel
In dinotrace-annotate-add-header:
dinotrace.el:749:8:Warning: `make-variable-buffer-local' should be called at
    toplevel
In dinotrace-annotate-sim-log-cursor:
dinotrace.el:878:28:Warning: `string-to-int' is an obsolete function (as of
    Emacs 22.1); use `string-to-number' instead.
In dinotrace-face-create:
dinotrace.el:1014:13:Warning: `internal-find-face' is an obsolete function (as
    of Emacs 21.1); use `facep' instead.
In dinotrace-send-command:
dinotrace.el:1276:22:Warning: `string-to-int' is an obsolete function (as of
    Emacs 22.1); use `string-to-number' instead.
Wrote /builddir/build/BUILD/dinotrace-9.3f/lisp/dinotrace.elc


Loading /usr/share/emacs/site-lisp/site-start.d/rpm-spec-mode-init.el
(source)...
In sim-log-font-lock-keywords:
sim-log.el:122:17:Warning: `font-lock-reference-face' is an obsolete variable;
    use `font-lock-constant-face' instead.
In end of data:
sim-log.el:171:1:Warning: the function `installer-add-file' is not known to be
    defined.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.