[Bug 483403] Review Request: gdesklet-citation - A collection of quotes in French for gdesklets

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=483403


Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |mtasaka at ioa.s.u-tokyo.ac.jp
               Flag|                            |fedora-review?




--- Comment #17 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp>  2009-03-07 13:44:11 EDT ---
Well, the trouble is that currently gdesklets itself won't
work on my rawhide machine :( However I will review this

Some notes:

* License
  - The license tag should be "GPL+", because no version
    is specified (putting GPLv2 license text is not enough
    to limit version)

* Name
  - should be gdesklet"s"-citation

* Requires
  - gdesklets already requires python 
    (gdesklets requires gnome-python2-gconf, and gnome-python2-gconf
     requires python)

! %define -> %global
  - For some reason (mainly because of unexpected behavior of
    %define on nested macros), now Fedora packaging guideline
    recommends to use %global instead of %define.

* %setup
----------------------------------------------------------
%setup -q -c %{name}-%{version} -a0
----------------------------------------------------------
  - "%setup -q -c" is enough.

* Directory ownership issue
  - The directory %{_datadir}/gdesklets/Displays/%{_appname}/
    must be owned by this package.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.