[Bug 470325] Review Request: qd - Double-Double and Quad-Double Arithmetic

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=470325


Jason Tibbitts <tibbs at math.uh.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |tibbs at math.uh.edu
               Flag|                            |fedora-review?




--- Comment #9 from Jason Tibbitts <tibbs at math.uh.edu>  2009-03-07 18:02:23 EDT ---
Sorry for not getting back to this sooner.

Any reason why you believe the license is GPLv2+?  The COPYING file included
the rather standard BSD license.  (The copyright is even held by UCB.)  The
actual source files are missing any license statment but README explicitly
refers to the COPYING file which contains the BSD text.  Generally we'd prefer
the source files to include license statements but I don't think the licensing
situation is ambiguous.  Of course, I could be missing something.

I would also comment why you're disabling the debug package, because it's not
immediately obvious from looking at the spec.

* source files match upstream.  sha256sum:
   c886c96ca8081196089fe00eac74765a43e7500ae27e2e107a7c4f10fa95b4f1  
   qd-2.3.7.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
X license field does not match the actual license.
* license is open source-compatible.
* license text included in package.
* latest version is being packaged.
* BuildRequires are proper.
* compiler flags are appropriate.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly.
* rpmlint is silent.
* final provides and requires are sane:
   qd-static = qd-2.3.7
   qd-devel = 2.3.7-4.fc11
   qd-devel(x86-64) = 2.3.7-4.fc11
  =
   /bin/sh

* %check is present and all tests pass:
   All 4 tests passed
* no shared libraries are added to the regular linker search paths.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no generically named files
* code, not content.
* documentation is small, so no -doc subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* headers are in the -devel package.
* no pkgconfig files.
* only static libraries are present:
  They are in the -devel package.
  -static is provided.
* no libtool .la files.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.