[Bug 483451] Review Request: k3guitune - Musical instrument tuner

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=483451





--- Comment #5 from Orcan 'oget' Ogetbil <oget.fedora at gmail.com>  2009-03-07 23:58:14 EDT ---
Actually, I spent some more time on this and finished the review. There are
only a few more issues remaining:

* Please remove the binary .gmo files in %prep

* You don't need explicit Requires: hicolor-icon-theme. kdelibs3 will pick that
up for you.

* %{_datadir}/doc/ must be replaced by %{_docdir}, especially in the %files
section.

* The files
   acinclude.m4
   admin/*
   configure.in
are LGPL. But they don't get into the final binary RPM. But some source files
under k3guitune directory are GPLv2+ and some are GPLv2 (no +). So the license
tag should be "GPLv2 and GPLv2+".

! You can remove the commented lines that you won't need. e.g.
   #%{_datadir}/doc/HTML/*en/common

! Each package must consistently use macros. 
   -The SPEC file contains mixed instances of both %{name} and k3guitune. 
    The former is preferred. 

   -Also in this notation, you should use %{__install} instead of install.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.