[Bug 483434] Review Request: argtable2 - A library for parsing GNU style command line arguments

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=483434


Michael Schwendt <bugs.michael at gmx.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bugs.michael at gmx.net




--- Comment #9 from Michael Schwendt <bugs.michael at gmx.net>  2009-03-08 08:01:40 EDT ---
* It is good packaging-practice to add

  %check
  make check

after the %install section.


* The -devel subpackage refers to "libargtable2" while the package is called
"argtable2" and the main pkg description calls the software "Argtable". This
inconsistency causes minor confusion. You could substitute "libargtable2" with
the project name, package %{name} or even "Argtable library".


* The %doc examples/Makefile.nmake is for MSVC.


* The %doc examples/Makefile contains a hardcoded '/lib', which won't work on
64-bit platforms. [As a side-note: Overriding -Iheader/-Llibrary search-paths
with default search-paths is a wide-spread mistake that causes unwanted
side-effects. Here it's just examples and therefore neglectable, but where you
see it in other software releases, try to get rid of it.]


* The %doc files are large enough to justify creating a -doc subpackage and
moving them there. If every -devel package included so much documentation,
creating buildroots and -devel spins would require a lot more resources.
argtable2-devel shrinks down to 6K from 3M (!).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.