[Bug 482763] Review Request: compat-guichan07 - compatibility libraries for guichan 0.7.1

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=482763


Alexey Torkhov <atorkhov at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |atorkhov at gmail.com
               Flag|                            |fedora-review+




--- Comment #3 from Alexey Torkhov <atorkhov at gmail.com>  2009-03-10 15:07:17 EDT ---
Well, this seem will work only for people that are built their packages but not
simply built againt guichan, as in latter case there will be no dep preventing
update from guichan-0.7 to guichan-0.8.

Anyway, here is review:

- rpmlint output:

compat-guichan07.x86_64: W: file-not-utf8
/usr/share/doc/compat-guichan07-0.7.1/COPYING
compat-guichan07.x86_64: W: file-not-utf8
/usr/share/doc/compat-guichan07-0.7.1/README
compat-guichan07.x86_64: W: file-not-utf8
/usr/share/doc/compat-guichan07-0.7.1/NEWS
compat-guichan07.x86_64: W: file-not-utf8
/usr/share/doc/compat-guichan07-0.7.1/AUTHORS
compat-guichan07-devel.x86_64: W: no-documentation
2 packages and 0 specfiles checked; 0 errors, 5 warnings.

Non-UTF8 files should be fixed for this and for 0.8, if it suffer from this
too.

+ The package is named according to the Package Naming Guidelines.
+ The spec file name matches the base package %{name}, in the format
  %{name}.spec.
+ The package meets the Packaging Guidelines.
+ The package is licensed with a Fedora approved license and meets the
  Licensing Guidelines.
+ The License field in the package spec file matches the actual license.
+ File, containing the text of the licenses for the package is included in
  %doc.
+ The spec file is written in American English.
+ The spec file for the package is legible.
+ The sources used to build the package matches the upstream source, as
  provided in the spec URL.

275c5bad231d2ce55e654d80cb1e05be  guichan-0.7.1.tar.gz
275c5bad231d2ce55e654d80cb1e05be  guichan-0.7.1.tar.gz

+ The package successfully compiles and builds into binary rpms on at least
  one primary architecture (x86_64).
+ All build dependencies are listed in BuildRequires.
+ No need to deal with locales.
+ Calls ldconfig in %post and %postun.
+ The package does not designed to be relocatable.
+ A package owns all directories that it creates.
+ A package does not contains any duplicate files in the %files listing.
+ Permissions on files are set properly.
+ The package has a %clean section, which contains rm -rf $RPM_BUILD_ROOT.
+ The package consistently uses macros.
+ The package contains code.
+ Does not contain large documentation.
+ Includes only doc files in %doc.
+ Header files are in a -devel package.
+ No static libraries.
+ No pkgconfig(.pc) files.
+ Library files without suffix are in a -devel package.
+ Devel package require the base package using a fully versioned dependency.
+ Packages does not contain any .la libtool archives.
+ Packages does not contain GUI application.
+ Packages does not own files or directories already owned by other packages.
+ At the beginning of %install, the package runs rm -rf $RPM_BUILD_ROOT.
+ All filenames in the package are valid UTF-8.

This package is APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.