[Bug 489564] Review Request: Blueman - Bluetooth Manager

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=489564


Christian Krause <chkr at plauener.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |chkr at plauener.de




--- Comment #4 from Christian Krause <chkr at plauener.de>  2009-03-11 16:26:15 EDT ---
Hi Juan,

I've done a rough review of your Review Request and there are a couple items
which needs to be addressed.

1. Since you're seeking sponsorship for the Packagers Group, please make your
Review Request block the FE-NEEDSPONSOR bug (see
http://fedoraproject.org/wiki/PackageMaintainers/Join for details)

2. The Source0: field refers to the subversion repository. If there is no
upstream tarball it is necessary to provide some information how the tarball
gets generated. For details please see here:
http://fedoraproject.org/wiki/Packaging/SourceURL . However, it this case it
looks like that upstream provides a tarball, so please refer to this location
in Source0:
http://download.tuxfamily.org/blueman/blueman-1.02.tar.gz

You can test whether you've used the correct URL by running
spectool -g SPECS/blueman.spec
it should download the correct source file.

3. The package doesn't build cleanly in mock since not all build requirements
are listed. Please setup mock locally - it is a big help to find missing build
requirements. ;)
For details please check the following wiki site:
http://fedoraproject.org/wiki/Extras/MockTricks

4. rpmlint is quite chatty about the spec file and the rpm files:

rpmlint SPECS/blueman.spec RPMS/i386/blueman-1.02-2.fc10.i386.rpm
RPMS/i386/blueman-debuginfo-1.02-2.fc10.i386.rpm
SRPMS/blueman-1.02-2.fc10.src.rpm
blueman.i386: E: zero-length /usr/share/doc/blueman-1.02/README
blueman.i386: W: non-conffile-in-etc /etc/xdg/autostart/blueman.desktop
blueman.i386: W: devel-file-in-non-devel-package
/usr/lib/python2.5/site-packages/_blueman.a
blueman.i386: E: zero-length /usr/share/doc/blueman-1.02/NEWS
blueman.i386: W: non-conffile-in-etc
/etc/dbus-1/system.d/org.blueman.Mechanism.conf
blueman.i386: W: invalid-license GPL v3
blueman-debuginfo.i386: W: invalid-license GPL v3
blueman.src: W: invalid-license GPL v3
3 packages and 1 specfiles checked; 2 errors, 6 warnings.

* zero-length files shouldn't be included

* please fix the license tag (see
http://fedoraproject.org/wiki/Packaging/Guidelines#Licensing and the links
there for details)

Using rpmlint helps to catch some well-known mistakes in spec files early. ;-)
http://fedoraproject.org/wiki/Packaging/Guidelines#Use_rpmlint

6. please don't package *.la files

7. *.a files should be omitted, too

8. to make the spec file more readable it is ok to use wildcards, e.g.:
%{_mandir}/man1/*
etc.

Please have a look at the mentioned items first and then I'll do a more
detailed review. If you have any questions, don't hesitate to ask!

Best regards,
Christian

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.