[Bug 490562] Review Request: renameutils - A set of programs to make renaming of files easier

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=490562





--- Comment #4 from Michael Ploujnikov <ploujj at gmail.com>  2009-03-17 20:26:01 EDT ---
(In reply to comment #3)
> A few initial notes:
> 
> - the URL
> URL:  http://www.nongnu.org/%{name}
> would be better as
> URL:  http://www.nongnu.org/renameutils
> 
> since that way you can open the link straight away from the spec file (you
> don't have to expand the macro yourself).

Fixed.

> - Remove
> Requires: readline
> as this is picked up automatically by rpmbuild.

Done.

> - Locales are not handled correctly, see
> http://fedoraproject.org/wiki/Packaging/Guidelines#Handling_Locale_Files

Done: http://plouj.com/rpmbuild/SPECS/renameutils.spec and
http://plouj.com/rpmbuild/SRPMS/renameutils-0.10.0-1.fc9.src.rpm .

> After you've fixed these I'll make the full review.
> 
> Also, as you are a new packager you should make a habit of running rpmlint on
> all your packages and paste the output in the Review Request every time you put
> in a new release (up to the package being accepted, that is).  

I'll do that. The only reason I didn't do it is because
https://fedoraproject.org/wiki/Package_Review_Process didn't mention it.
However, for my package rpmlint (0.85) doesn't print any errors/warnings:

$ rpmlint /home/plouj/rpmbuild/RPMS/x86_64/renameutils-0.10.0-1.fc9.x86_64.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

$ rpmlint
/home/plouj/rpmbuild/RPMS/x86_64/renameutils-debuginfo-0.10.0-1.fc9.x86_64.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

$ rpmlint /home/plouj/rpmbuild/SRPMS/renameutils-0.10.0-1.fc9.src.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.