[Bug 490317] Review Request: rumor - Really Unintelligent Music transcriptOR

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=490317





--- Comment #2 from Orcan 'oget' Ogetbil <oget.fedora at gmail.com>  2009-03-21 03:12:54 EDT ---
(In reply to comment #1)

> * rpmlint: TODO
> rpmlint SPECS/rumor.spec RPMS/i386/rumor-* SRPMS/rumor-1.0.3b-1.fc10.src.rpm
> SPECS/rumor.spec: W: mixed-use-of-spaces-and-tabs (spaces: line 12, tab: line
> 1)
> rumor.src: W: mixed-use-of-spaces-and-tabs (spaces: line 12, tab: line 1)
> 3 packages and 1 specfiles checked; 0 errors, 2 warnings.
> - just a very minor mixture of spaces and tabs
> 

I wonder how this rpmlint survived all my checks. Fixed!


> * optflags: TODO
> - I would delete the -O0 in the configure file completely and not substitute it
> with -O2. If Fedora changes the rpmoptflags, there will be two different -Ox
> options (the one from rpmoptflags and the one from the configure) (e.g. "sed -i
> 's|-O0||' configure" could be used)
> - the only uncommon gcc option is "-ggdb3", but that's no problem, it will only
> add some more info to the debug infos (e.g. macros) - gdb works still fine with
> rumor's debuginfo
> 

Good point. Thanks for bringing this up. 

Spec URL: http://oget.fedorapeople.org/review/rumor.spec
SRPM URL: http://oget.fedorapeople.org/review/rumor-1.0.3b-2.fc10.src.rpm

Thank you Christian, once more :)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.