[Bug 458826] Review Request: s390utils - Linux/390 specific utilities

bugzilla at redhat.com bugzilla at redhat.com
Wed Mar 25 12:09:16 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=458826





--- Comment #9 from Dan Horák <dan at danny.cz>  2009-03-25 08:08:51 EDT ---
(In reply to comment #8)
> A few additional comments:
> 
> Is there really no download location for the three tarballs?  If there's any
> way to get them, you need to either use full URLs on the Source: lines or, if
> the URLs are weird and RPM can't handle them, include them as comments.  See
> http://fedoraproject.org/wiki/Packaging/SourceURL.

Direct URLs for the sources are added with user-clickable URLs in comments.

> In a multiple license scenario, there needs to be some documentation of which
> parts of the package are under which license.  See
> http://fedoraproject.org/wiki/Packaging/LicensingGuidelines

Each subpackage should have proper license tag and I will work with the IBM
developers on a licensing overview for the individual utilities.

> I'm not really sure there's any point in having "Linux -" in those summary
> entries.  Isn't it a bit obvious?
> 
> The compiler ends up being called with -O3.  I'm not sure this is a big deal,
> really, but generally we like to see the default set of compiler flags applied.

Thanks for catching this, parts other than the s390-tools were even built
without our CFLAGS.

> I'm pretty sure that everything else about this package is OK, but there's a
> lot there.  

yes, it is ...


Updated Spec URL: http://fedora.danny.cz/s390/s390utils.spec
Updated SRPM URL: http://fedora.danny.cz/s390/s390utils-1.8.0-5.el5.src.rpm

Koji scratch build:
http://s390.koji.fedoraproject.org/koji/taskinfo?taskID=23348

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list