[Bug 479008] Review Request: libQGLViewer - Qt based OpenGL generic 3D viewer library

bugzilla at redhat.com bugzilla at redhat.com
Wed Mar 25 17:27:22 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=479008


Lubomir Rintel <lkundrak at v3.sk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lkundrak at v3.sk
         AssignedTo|nobody at fedoraproject.org    |lkundrak at v3.sk
               Flag|                            |fedora-review+




--- Comment #4 from Lubomir Rintel <lkundrak at v3.sk>  2009-03-25 13:26:58 EDT ---
1.) No useless comments please

#Obsoletes:     %{name}-designer-plugin < %{version}-%{release}

2.) This is useless, even gcc itself grabs this in:

BuildRequires:  glibc-common

* Source file matches upstream
* SPEC file is clean and legible
* Builds fine in mock
(http://koji.fedoraproject.org/koji/taskinfo?taskID=1258482)
* File list looks sane
* Requires/Provides are sane
* Headers and libraries files in -devel
* Compile flags used properly
* Checked for functionality (built and run skyviewer)

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list