[Bug 225886] Merge Review: hfsutils

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=225886





--- Comment #2 from Jussi Lehtola <jussi.lehtola at iki.fi>  2009-03-27 09:42:38 EDT ---
rpmlint output:
hfsutils.src:202: W: macro-in-%changelog defattr
hfsutils.src: W: summary-ended-with-dot Tools for reading and writing Macintosh
HFS volumes.
hfsutils.x86_64: W: summary-ended-with-dot Tools for reading and writing
Macintosh HFS volumes.
hfsutils-devel.x86_64: W: no-documentation
hfsutils-devel.x86_64: W: summary-ended-with-dot A C library for reading and
writing Macintosh HFS volumes.
hfsutils-x11.x86_64: W: summary-ended-with-dot A Tk-based front end for
browsing and copying files.
5 packages and 0 specfiles checked; 0 errors, 6 warnings.

- Fix the above. 

- Drop empty %config line in %files.

- Change buildroot to
%(mktemp -ud %{_tmppath}/%{name}-%{version}-%{release}-XXXXXX)

- Drop INSTALL from %doc since it really isn't necessary. Also README can be
dropped, since it is too about compilation.


MUST: The spec file for the package is legible and macros are used
consistently. OK
MUST: The package must be named according to the Package Naming Guidelines. OK
MUST: The spec file name must match the base package %{name}. OK
MUST: The package must be licensed with a Fedora approved license and meet the 
Licensing Guidelines. OK
MUST: The License field in the package spec file must match the actual license.
OK
MUST: The sources used to build the package must match the upstream source, as
provided in the spec URL. OK
MUST: The package MUST successfully compile and build into binary rpms. OK
MUST: The spec file MUST handle locales properly. OK
MUST: Optflags are used and time stamps preserved. OK
 SHOULD: Use INSTALL="install -p" as additional argument to make install to
preserve time stamps.
MUST: Packages containing shared library files must call ldconfig. OK
MUST: A package must own all directories that it creates or require the package
that owns the directory. OK
MUST: Files only listed once in %files listings. OK
MUST: Permissions on files must be set properly. OK
MUST: Clean section exists. OK
MUST: Large documentation files must go in a -doc subpackage. OK
MUST: Items in %doc do not affect runtime of application. OK
MUST: Header files must be in a -devel package. OK
MUST: Static libraries must be in a -static package. NEEDSFIX
 - Devel package needs to provide %{name}-static = %{version}-%{release}
MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig'. OK
MUST: If a package contains library files with a suffix then library files 
ending in .so must go in a -devel package. OK
MUST: In the vast majority of cases, devel packages must require the base
package using a fully versioned dependency. ?
 - Any comment on this? In this case base package only contains binaries, so
there's no need to require the base package. Consider including the %doc also
in -devel, though.
MUST: Packages does not contain any .la libtool archives. OK
MUST: Desktop files are installed properly. OK
MUST: No file conflicts with other packages and no general names. OK
MUST: Buildroot cleaned before install. OK
SHOULD: %{?dist} tag is used in release. OK
SHOULD: If the package does not include license text(s) as separate files from
upstream, the packager should query upstream to include it. OK
SHOULD: The package builds in mock. OK

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.