[Bug 492165] Review Request: rotoscope - A free rotoscoping application.

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=492165


Kalev Lember <kalev at smartlink.ee> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kalev at smartlink.ee




--- Comment #1 from Kalev Lember <kalev at smartlink.ee>  2009-03-27 19:55:07 EDT ---
Some initial comments:

1) You have a typo in %install section. It should read %{buildroot}, not
%{buidroot}.

2) A package should own all the directories it creates, otherwise it will leave
empty directories behind when you uninstall it. Change:
%{_datadir}/%{name}/%{name}.*
to:
%{_datadir}/%{name}/

3) remove dot at the end of summary line;

4) NEWS file seems to be empty, so just don't install it;

5) rpmlint complains about mixed-use-of-spaces-and-tabs;

6) in the SRPM file you have execute bit set on both the spec file and the
patch;

7) Licence is wrong. It seems to be GPLv2+, not GPLv2 as you have set in the
spec file.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.