[Bug 476346] Review Request: python-polybori - Framework for Boolean Rings

bugzilla at redhat.com bugzilla at redhat.com
Sun Mar 29 17:06:41 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=476346





--- Comment #19 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp>  2009-03-29 13:06:39 EDT ---
Created an attachment (id=337176)
 --> (https://bugzilla.redhat.com/attachment.cgi?id=337176)
Patch to build libcuddobj.so

Well,
- python-polybori side now seems good (I have not retried full review
  yet)
- however cudd side is not yet good,

as libpolybori.so cannot resolve defaultError(std::string) symbol:
-----------------------------------------------------
# ldd -r /usr/lib/libpolybori-0.5.0.so
undefined symbol: _Z12defaultErrorSs    (/usr/lib/libpolybori-0.5.0.so)
        linux-gate.so.1 =>  (0x00e7d000)
        libcudd.so.2 => /usr/lib/libcudd.so.2 (0x00f24000)
        libm4ri-0.0.20081029.so => /usr/lib/libm4ri-0.0.20081029.so
(0x0050c000)
        libstdc++.so.6 => /usr/lib/libstdc++.so.6 (0x006b8000)
        libm.so.6 => /lib/libm.so.6 (0x0057e000)
        libgcc_s.so.1 => /lib/libgcc_s.so.1 (0x005f0000)
        libc.so.6 => /lib/libc.so.6 (0x00110000)
        libmtr.so.2 => /usr/lib/libmtr.so.2 (0x00281000)
        libcuddst.so.2 => /usr/lib/libcuddst.so.2 (0x00abf000)
        libcuddutil.so.2 => /usr/lib/libcuddutil.so.2 (0x00b9a000)
        libepd.so.2 => /usr/lib/libepd.so.2 (0x00c75000)
        /lib/ld-linux.so.2 (0x00b76000)
-------------------------------------------------------

As I said in the previous comment defaultError(std::string) is
defined in obj/cuddObj.cc
- A extra library under obj needs building. This library is not built
  by default so a patch is needed. Your patch builds a static archive
  under obj/ but does not seem to build shared library under obj/ .

  ! By the way the library under obj/ directory is named as libobj.so,
    however I think this naming is very bad and this library should be
    renamed as libcuddobj.so .
  ! Also without a path the rebuilt libcuddobj.so (after renamed)
    library is broken as this contains undefined non-weak symbols :(,
    because
    - although this is C++ library, "cc" is used for linkage.
      Note that libcudd.so is C library
    - this library is not properly linkaged against libcudd.so

  For me libcuddobj.so can be properly built by the attached patch.

- After this, libpolybori.so and libgroebner.so should be
  linkaged against both libcudd.so and libcuddobj.so.

  ! Note
    First I tried to merge libcuddobj.so into libcudd.so, however
    as said before libcudd.so is C library but libcuddobj.so contains
    C++ function, so this should not be done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list