[Bug 491430] Review Request: sslogger - A keystroke logging utility for privileged user escalation
bugzilla at redhat.com
bugzilla at redhat.com
Mon Mar 30 17:55:58 UTC 2009
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=491430
Gratien D'haese <gratien.dhaese at it3.be> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |gratien.dhaese at it3.be
--- Comment #10 from Gratien D'haese <gratien.dhaese at it3.be> 2009-03-30 13:55:57 EDT ---
Please start with reading:
https://fedoraproject.org/wiki/PackageMaintainers/CreatingPackageHowTo or
https://fedoraproject.org/wiki/Packaging/Guidelines for further details.
It will help you to improve the spec file.
Please use the "rpmlint" program to validate the spec/rpm/srpm package.
Once you show the output of rpmlint without errors I'll digg into your package
for further assistance.
# rpmlint -vi sslogger.spec
sslogger.spec:7: W: hardcoded-path-in-buildroot-tag /%{_tmppath}/%{name}-root
A path is hardcoded in your Buildroot tag. It should be replaced by something
like %{_tmppath}/%name-root.
sslogger.spec:10: W: hardcoded-packager-tag Ed
The Packager tag is hardcoded in your spec file. It should be removed, so as
to use rebuilder's own defaults.
sslogger.spec:27: W: rpm-buildroot-usage %prep if [ -n "%{buildroot}" ]; then
$RPM_BUILD_ROOT should not be touched during %build or %prep stage, as it will
break short circuiting.
sslogger.spec:28: W: rpm-buildroot-usage %prep if [ "%{buildroot}" != "/" ];
then
$RPM_BUILD_ROOT should not be touched during %build or %prep stage, as it will
break short circuiting.
sslogger.spec:29: W: rpm-buildroot-usage %prep echo removing %{buildroot}
$RPM_BUILD_ROOT should not be touched during %build or %prep stage, as it will
break short circuiting.
sslogger.spec:30: W: rpm-buildroot-usage %prep rm -rf %{buildroot}
$RPM_BUILD_ROOT should not be touched during %build or %prep stage, as it will
break short circuiting.
sslogger.spec: E: no-cleaning-of-buildroot %install
You should clean $RPM_BUILD_ROOT in the %clean section and just after the
beginning of %install section. Use "rm -Rf $RPM_BUILD_ROOT".
sslogger.spec: E: no-cleaning-of-buildroot %clean
You should clean $RPM_BUILD_ROOT in the %clean section and just after the
beginning of %install section. Use "rm -Rf $RPM_BUILD_ROOT".
0 packages and 1 specfiles checked; 2 errors, 6 warnings.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the Fedora-package-review
mailing list