[Bug 454980] Review Request: axel - Download accelerator, wget replacement

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=454980





--- Comment #35 from Pavel Alexeev (aka Pahan-Hubbitus) <pahan at hubbitus.info>  2009-03-30 14:49:28 EDT ---
(In reply to comment #34)
> Comment 14 starts with comments on the the buffer overflow/security issues.
I file bug to upstream https://bugzilla.redhat.com/show_bug.cgi?id=454980#c14

> > Hmmm. It is generated by standard %find_lang macros.
> It isn't. The %find_lang macro only finds message/translation object files.
And generate file of list it. Aftre that it used also in standard way:
%files -f %{name}.lang

What there wrong?

> > configure patched to use those flags. I assume there all right.
> Not true. Wrong assumption.  
I had to disagree there.
In standard configure script it place this flags 'CFLAGS=-D_LARGEFILE_SOURCE
-D_FILE_OFFSET_BITS=64 -g -Os' into Makefile.settings.
But as you can see in build.log it compiled with standard Fedora flags, where
only few upstrem defined flagw was reseeded:

CFLAGS='-O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions
-fstack-protector --param=ssp-buffer-size=4 -m32 -march=athlon
-fasynchronous-unwind-tables'
...
gcc -c axel.c -o axel.o -Wall -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2
-fexceptions -fstack-protector --param=ssp-buffer-size=4 -m32 -march=athlon
-fasynchronous-unwind-tables -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -g -Os

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.