[Bug 498371] Review Request: fedora-devshell - Fedora Developer's Toolbox

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=498371





--- Comment #3 from Jussi Lehtola <jussi.lehtola at iki.fi>  2009-05-01 03:10:53 EDT ---
rpmlint output:
fedora-devshell.noarch: E: description-line-too-long Fedora Devshell is a
developers toolbox for creating packages and developing software for Fedora. It
aims to simplify the process of creating and maintaining packages in the Fedora
repositories, and simplify the workflow between other Fedora components.
fedora-devshell.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/devshell/devshell.py 0644
fedora-devshell.noarch: E: non-executable-script
/usr/lib/python2.5/site-packages/devshell/ports.py 0644
fedora-devshell.src: E: description-line-too-long Fedora Devshell is a
developers toolbox for creating packages and developing software for Fedora. It
aims to simplify the process of creating and maintaining packages in the Fedora
repositories, and simplify the workflow between other Fedora components.
2 packages and 0 specfiles checked; 4 errors, 0 warnings.

- You need to break the description lines to match the 80 character width
restricition.

- Either add executable bits to devshell.py and ports.py or remove their
shebangs to fix the non-executable-script problem. Python library files should
not have shebangs; please contact upstream to remove them.

MUST: The package does not yet exist in Fedora. The Review Request is not a
duplicate. OK
MUST: The spec file for the package is legible and macros are used
consistently. OK
MUST: The package must be named according to the Package Naming Guidelines. OK
MUST: The spec file name must match the base package %{name}. OK
MUST: The package must be licensed with a Fedora approved license and meet the 
Licensing Guidelines. OK

MUST: The License field in the package spec file must match the actual license.
NEEDSFIX
- License is GPLv2, not GPLv2+.

MUST: The sources used to build the package must match the upstream source, as
provided in the spec URL. NEEDSFIX
- No source URL provided. http://fedoraproject.org/wiki/Packaging/SourceURL

MUST: The package MUST successfully compile and build into binary rpms. OK
MUST: The spec file MUST handle locales properly. OK
MUST: Optflags are used and time stamps preserved. OK
MUST: Packages containing shared library files must call ldconfig. OK

MUST: A package must own all directories that it creates or require the package
that owns the directory. ~OK
- Instead of using
 %{python_sitelib}/*
please use
 %{python_sitelib}/devshell/
 %{python_sitelib}/%{name}-*.egg-info
instead, as this is more likely to pick up errors.

MUST: Files only listed once in %files listings. OK
MUST: Permissions on files must be set properly. OK
MUST: Clean section exists. OK
MUST: Large documentation files must go in a -doc subpackage. OK

MUST: All relevant items are included in %doc. Items in %doc do not affect
runtime of application. NEEDSFIX
- Add PKG-INFO to %doc.

MUST: Desktop files are installed properly. OK
MUST: No file conflicts with other packages and no general names. OK
MUST: Buildroot cleaned before install. OK
SHOULD: %{?dist} tag is used in release. OK
SHOULD: If the package does not include license text(s) as separate files from
upstream, the packager should query upstream to include it. OK
SHOULD: The package builds in mock. OK

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.