[Bug 498490] Review Request: smem - Reports application memory usage in a meaningful way

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=498490





--- Comment #13 from Jussi Lehtola <jussi.lehtola at iki.fi>  2009-05-01 03:26:26 EDT ---
rpmlint output is clean.


MUST: The package does not yet exist in Fedora. The Review Request is not a
duplicate. OK
MUST: The spec file for the package is legible and macros are used
consistently. OK
MUST: The package must be named according to the Package Naming Guidelines. OK
MUST: The spec file name must match the base package %{name}. OK
MUST: The package must be licensed with a Fedora approved license and meet the 
Licensing Guidelines. OK

MUST: The License field in the package spec file must match the actual license.
NEEDSFIX
- There is nothing mentioned about a license in the tarball => the tarball has
no license.
- Since the GPLv2+ license is in upstream svn, use a svn revision for now,
until upstream releases a stable tarball with a license. (Of course, you can
ask upstream to make a new stable release with the license info ASAP.)

MUST: The sources used to build the package must match the upstream source, as
provided in the spec URL. OK
MUST: The package MUST successfully compile and build into binary rpms. OK
MUST: The spec file MUST handle locales properly. OK

MUST: Optflags are used and time stamps preserved. NEEDSFIX
- Use "cp -a" instead of plain "cp" in setup phase.
- Also, use
 install -D -p -m 755 smem $RPM_BUILD_ROOT/%{_bindir}/smem
to preserve the time stamp of the python file itself. -D creates the directory
if necessary, so you can drop the dir creation line:
 install -p -d $RPM_BUILD_ROOT/%{_bindir}

MUST: Packages containing shared library files must call ldconfig. OK
MUST: A package must own all directories that it creates or require the package
that owns the directory. OK
MUST: Files only listed once in %files listings. OK
MUST: Permissions on files must be set properly. OK
MUST: Clean section exists. OK
MUST: Large documentation files must go in a -doc subpackage. OK
MUST: All relevant items are included in %doc. Items in %doc do not affect
runtime of application. OK
MUST: Desktop files are installed properly. OK
MUST: No file conflicts with other packages and no general names. OK
MUST: Buildroot cleaned before install. OK
SHOULD: %{?dist} tag is used in release. OK

SHOULD: If the package does not include license text(s) as separate files from
upstream, the packager should query upstream to include it. NEEDSFIX
- Use the svn revision until upstream releases a new tarball with license
information included.

SHOULD: The package builds in mock. OK

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.