[Bug 464117] Review Request: perl-SVN-Notify - Perl module for Subversion activity notification

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=464117


Jochen Schmitt <jochen at herr-schmitt.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jochen at herr-schmitt.de




--- Comment #7 from Jochen Schmitt <jochen at herr-schmitt.de>  2009-05-04 13:30:12 EDT ---
1.) What this line should mean?

Requires:       perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo
$version))

This may caused, that you have to rebuild your package for every new perl
version which will been released.

2.) For what do you need this statements?

find $RPM_BUILD_ROOT -type d -depth -exec rmdir {} 2>/dev/null \;

chmod -R u+rwX,go+rX,go-w $RPM_BUILD_ROOT/*

Keep in mind, that <ou can set file permissions in the %files stanza.

It may be nice to subsitute

Requires:       perl-SVN-Notify


into

Requires:       perl-SVN-Notify = %{version}-%{release}

The scratch build on koji works fine. I will sponsor you, if we can finished
this review.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.