[Bug 497035] Review Request: creox - Real-time Sound Processor

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=497035





--- Comment #2 from Christian Krause <chkr at plauener.de>  2009-05-05 18:06:27 EDT ---
Hi Orcan,

please apologize the delay of the review. Here it is:

* rpmlint:  OK
rpmlint SPECS/creox.spec SRPMS/creox-0.2.2-0.1.rc2.fc10.src.rpm
RPMS/i386/creox-*
creox.i386: W: dangling-symlink /usr/share/doc/HTML/en/creox/common
/usr/share/doc/HTML/en/common
3 packages and 1 specfiles checked; 0 errors, 1 warnings.

- as Orcan said, this is a false warning, the target of the symlink is provided
by kdelibs-common which is required by kdelibs3 which are required via library
dependencies by creox (and so the installed package will not have dangling
symlinks)

* naming: OK
- name matches upstream
- spec file name matches package name
- non-numeric release handled according:
http://fedoraproject.org/wiki/Packaging/NamingGuidelines#NonNumericRelease

* License: OK
- GPLv2 acceptable
- GPLv2 (as published) referenced in source files as well as in the COPYING
file
- COPYING file packaged

* specfile in American English and legible: OK

* Sources: OK
- Source0 URL ok
- spectool -g creox.spec works
- sources matches upstream - md5sum: 11d87ad6d47274fdf3f3236f5e09d6fd

* Patch0: TODO
- it is recommended to send the patches upstream and add a short comment
in the spec file about the status of the bug report

* Compilation: TODO
- mock build works
- package builds correctly in koji for F12, F11 and F10
- auto* tools adds additionally "-O2" (via acinclude.m4) - this is not a
problem right now, but probably if Fedora changes once its default optimization
flags then the package would be compiled with "-O2 -O3" or something like this
(I don't consider this as a big issue, but if it could be solved easily, then
it should be fixed IMHO)

* debuginfo sub-package: OK
- non-empty
- debuginfo file works together with gdb

* BuildRequires: OK

* Locales handling: OK
- %find_lang used
- gettext in BuildRequires

* shared/static libs, pkgconfig/header/*.la files: OK (n/a)

* packages must own all directories: TODO
- in general OK
- just a very minor suggestion: %{_datadir}/apps/%{name} should better be
%{_datadir}/apps/%{name}/ (just to indicate that really a directory and not a
file gets packaged)

* files not listed twice: OK
* permissions of files: OK
- %defattr used
- final file permissions OK

* %clean section: OK

* macro usage: OK

* code vs. content: OK (only code)

* large documentation into subpackage: OK (n/a)

* GUI application needs %{name}.desktop: OK
- custom desktop file added
- package appears correctly in (gnome) menu
- icon tag OK

* no directories owned which are already owned by other packages: OK

* rm -rf %{buildroot} at the beginning of %{install}: OK

* all filenames UTF8: OK

* functional test: TODO
- program starts and can be used
- however, when I press "play", I get an message box "Error:" (the sound
settings are not touched, all channels are set to "alsa_pcm:capture_1/2" or
"alsa_pcm:playback_1/2" ) - I'm not sure whether there is any need to configure
any jack-related settings in my system...

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.