[Bug 498849] Review Request: klatexformula - Application for easy image creating from a LaTeX equation

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=498849





--- Comment #7 from nucleo <alekcejk at googlemail.com>  2009-05-05 19:23:15 EDT ---
Spec URL:
http://nucleo.fedorapeople.org/pkg-reviews/klatexformula/klatexformula.spec

SRPM URL:
http://nucleo.fedorapeople.org/pkg-reviews/klatexformula/klatexformula-3.0.1-3.fc10.src.rpm


(In reply to comment #6)
> - You can get the package to build shared libraries very easily: add the line
>  sed -i "s|LIBRARY_TYPE = staticlib||g" src/klfbackend/klfbackend.pro
> after the setup phase. Remember to add
>  Requires: %{name} = %{version}-%{release}
> to the devel package and remove the Provides: %{name}-static line.

I made libklfbackend  subpackage with shared libraries and libklfbackend-devel
with header packages.


> rpmlint output is clean.

$ rpmlint klatexformula-3.0.1-3.fc10.src.rpm
klatexformula-3.0.1-3.fc12.i586.rpm
klatexformula-debuginfo-3.0.1-3.fc12.i586.rpm
libklfbackend-3.0.1-3.fc12.i586.rpm libklfbackend-devel-3.0.1-3.fc12.i586.rpm
5 packages and 0 specfiles checked; 0 errors, 0 warnings.


> MUST: The License field in the package spec file must match the actual license.
> NEEDSFIX
> - License is GPLv2+ not GPLv2.

License field fixed.


> MUST: The package MUST successfully compile and build into binary rpms. OK

Scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=1337883

I made patch that fixes build with GCC 4.4
http://nucleo.fedorapeople.org/pkg-reviews/klatexformula/klatexformula-gcc44.patch


> MUST: Packages containing shared library files must call ldconfig. N/A

There are ldconfig in libklfbackend package


> MUST: All relevant items are included in %doc. Items in %doc do not affect
> runtime of application. NEEDSFIX
> - Since devel package doesn't require (and consisting only of a static library
> doesn't need to either) the main package, add AUTHORS and COPYING to %doc of
> devel package too.

AUTHORS, README and COPYING now in libklfbackend package too, in
libklfbackend-devel there is only README because it requires libklfbackend.


> MUST: Header files must be in a -devel package. OK

Header files now in libklfbackend-devel package.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.