[Bug 499531] Review Request: kde-plasma-yawp - Yet Another Weather Plasmoid

bugzilla at redhat.com bugzilla at redhat.com
Fri May 8 05:41:57 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=499531


Parag AN(पराग) <panemade at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |panemade at gmail.com
         AssignedTo|nobody at fedoraproject.org    |panemade at gmail.com
               Flag|                            |fedora-review+




--- Comment #1 from Parag AN(पराग) <panemade at gmail.com>  2009-05-08 01:41:56 EDT ---
Review:
+ package builds in mock (rawhide i586).
koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1340028
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
3ffe00e0c9c55ecbf3f528188d84d957e3dcd7f6  yawp-0.2.3.tar.bz2
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ desktop file installed correctly.
+ file permissions are appropriate.
+ Package kde-plasma-yawp-0.2.3-1.fc12.i586
Provides: plasma_yawp.so
Requires: libQtCore.so.4 libQtDBus.so.4 libQtGui.so.4 libQtNetwork.so.4
libQtSvg.so.4 libQtXml.so.4 libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1)
libc.so.6(GLIBC_2.1.3) libgcc_s.so.1 libkdecore.so.5 libkdeui.so.5 libkio.so.5
libm.so.6 libplasma.so.3 libpthread.so.0 libsolid.so.4 libstdc++.so.6
libstdc++.so.6(CXXABI_1.3) libstdc++.so.6(GLIBCXX_3.4) rtld(GNU_HASH)

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list